Skip to content

Updated references to debian:stretch with debian:stretch-slim#1387

Merged
vdice merged 1 commit intomainfrom
unknown repository
Dec 16, 2020
Merged

Updated references to debian:stretch with debian:stretch-slim#1387
vdice merged 1 commit intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 16, 2020

What does this change

Updated references to debian:stretch with debian:stretch-slim

What issue does it fix

Closes #1380

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

@ghost ghost requested review from carolynvs, jeremyrickard and vdice as code owners December 16, 2020 12:55
Signed-off-by: Jeetu Kumar <66921514+i-am-jeetu@users.noreply.github.com>
@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 16, 2020

Hi, I need help with my first contribution to Porter.

I think there might be some error with the tests -

  1. Reason for failure is command '/bin/sh -c pip3 install sfctl' returned a non-zero code: 1 which is totally unrelated to changes.
  2. E2E on Windows is failing while on Linux it passes.

@vdice
Copy link
Copy Markdown
Member

vdice commented Dec 16, 2020

Hi @i-am-jeetu , thanks so much for this PR! I re-triggered the build and verified the windows E2E tests passed (perhaps we hit an agent problem on the first run). I'll look into the service-fabric-cli example build separately -- indeed, none of your changes would have provoked this failure.

Copy link
Copy Markdown
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vdice vdice merged commit fe8db03 into getporter:main Dec 16, 2020
@ghost ghost deleted the update-invocation-image branch December 18, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update references to debian:stretch with debian:stretch-slim

1 participant