Skip to content

fix(examples/service-fabric-cli): fix Dockerfile build#1388

Merged
carolynvs merged 2 commits intogetporter:mainfrom
vdice:fix/sfcli-example
Dec 21, 2020
Merged

fix(examples/service-fabric-cli): fix Dockerfile build#1388
carolynvs merged 2 commits intogetporter:mainfrom
vdice:fix/sfcli-example

Conversation

@vdice
Copy link
Copy Markdown
Member

@vdice vdice commented Dec 16, 2020

What does this change

  • Fix for a build failure for this example bundle as seen in (unrelated PR) Updated references to debian:stretch with debian:stretch-slim #1387
  • Once the above was fixed, we hit an issue wherein we hadn't pinned the json validator cli (ajv-cli) to a version and were hence pulling latest. There are breaking changes in the latest (perhaps we can look into this at a later date); for now, we pin to a known quantity (3.3.0)

What issue does it fix

N/A

Notes for the reviewer

N/A

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

Signed-off-by: Vaughn Dice <vadice@microsoft.com>
Signed-off-by: Vaughn Dice <vadice@microsoft.com>
@vdice vdice force-pushed the fix/sfcli-example branch from 46f9a00 to 4a6e6aa Compare December 16, 2020 20:24
@vdice
Copy link
Copy Markdown
Member Author

vdice commented Dec 16, 2020

Appear to be hitting #1389 (or a variant thereof)

Or maybe diff... this time the Win agent is stalled with:

"C:\windows\system32\cmd.exe" /D /E:ON /V:OFF /S /C "CALL "C:\a\_temp\0da71b6d-8267-41c0-8df3-0ab4d16302ef.cmd""
docker: error during connect: Post http://%2F%2F.%2Fpipe%2Fdocker_engine/v1.40/containers/create?name=registry: open //./pipe/docker_engine: The system cannot find the file specified. In the default daemon configuration on Windows, the docker client must be run elevated to connect. This error may also indicate that the docker daemon is not running.
See 'docker run --help'.

@carolynvs
Copy link
Copy Markdown
Member

/azp run porter

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@carolynvs
Copy link
Copy Markdown
Member

Docker crashed on the windows agent and didn't restart. For now I have deleted the unhealthy agent so that Azure will provision a new one. Later I'll look into preventing that from happening in the future.

@carolynvs
Copy link
Copy Markdown
Member

Docker is configured to check for new versions I think. So it's hanging and preventing the docker service from starting. I'm going to see about fixing the agent image to not check for updates since it's so disruptive.

Copy link
Copy Markdown
Member

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning FTW! 🧷

@carolynvs carolynvs merged commit d4b31bb into getporter:main Dec 21, 2020
@vdice vdice deleted the fix/sfcli-example branch December 21, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants