fix: Address verified Warden findings#477
Merged
Merged
Conversation
Keep project scans within their workspace boundary, treat diagnostic filenames as literal glob input, and preserve simulator lookup error contracts for malformed simctl output. Fixes #424
commit: |
cameroncooke
marked this pull request as ready for review
July 16, 2026 16:18
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5203ebd. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the three reproducible findings from #424. Project discovery now enforces real path boundaries instead of prefix matching, compiler diagnostic lookup treats glob metacharacters in filenames literally, and simulator lookup returns its documented error result when
simctlemits malformed JSON or device data.The boundary handling also preserves discovery when the configured workspace root is itself an Xcode bundle. The other Warden findings are intentionally outside this PR because they were not accepted as actionable in this review.
Fixes #424