Skip to content

fix(dashboard): enrich 400 errors on create to surface plan-limit messages (CLI-1J8)#893

Merged
BYK merged 1 commit intomainfrom
fix/dashboard-create-400-cli-1j8
Apr 30, 2026
Merged

fix(dashboard): enrich 400 errors on create to surface plan-limit messages (CLI-1J8)#893
BYK merged 1 commit intomainfrom
fix/dashboard-create-400-cli-1j8

Conversation

@BYK
Copy link
Copy Markdown
Member

@BYK BYK commented Apr 30, 2026

Summary

  • Widen enrichDashboardError to handle 400 on create (not just update), so plan-limit messages like "You may not exceed 10 dashboards on your current plan." surface clearly instead of a raw ApiError: Failed to create dashboard: 400 Bad Request
  • Add test for 400 on create with plan-limit detail

Fixes CLI-1J8.

Note: CLI-1JD (explore 400 from open-ended time ranges) was already fixed in #884.

@github-actions
Copy link
Copy Markdown
Contributor

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://cli.sentry.dev/_preview/pr-893/

Built to branch gh-pages at 2026-04-30 19:20 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@github-actions
Copy link
Copy Markdown
Contributor

Codecov Results 📊

6378 passed | Total: 6378 | Pass Rate: 100% | Execution Time: 0ms

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +1
Passed Tests 📈 +1
Failed Tests
Skipped Tests

All tests are passing successfully.

✅ Patch coverage is 83.33%. Project has 13166 uncovered lines.
✅ Project coverage is 75.89%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
src/commands/dashboard/resolve.ts 83.33% ⚠️ 1 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    75.89%    75.89%        —%
==========================================
  Files          294       294         —
  Lines        54604     54606        +2
  Branches         0         0         —
==========================================
+ Hits         41440     41440         —
- Misses       13164     13166        +2
- Partials         0         0         —

Generated by Codecov Action

@BYK BYK merged commit 697f23c into main Apr 30, 2026
35 of 37 checks passed
@BYK BYK deleted the fix/dashboard-create-400-cli-1j8 branch April 30, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant