fix(projects): confirm before discarding unsaved project edits - #148
Merged
Conversation
`Never mind` called `onCancel` immediately, so a stray click threw away everything typed into the project form. It now asks for confirmation whenever the form differs from the values it started with. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JoshuaKGoldberg
marked this pull request as ready for review
August 18, 2026 16:10
HazAT
self-requested a review
August 18, 2026 18:55
HazAT
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Never mindon the project form calledonCancelwith no dirty check, so one stray click silently threw away everything typed in. (slack thread)The form now:
initialValues(project, claim)helper used both for theuseStateinitializers and for adirtycomparisonNever mindask with a modal before discarding when anything differs🤖 Generated with Claude Code