feat(github): add trusted data to check events - #1363
Merged
Conversation
Give check suite events action handles (SHA, suite id/url, failing checks) so Junior can act without rediscovering CI state on every turn. Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
sentry-junior
Bot
changed the title
Simplify issue, PR, docs, and agent-facing wording around trusted check event data. Co-Authored-By: David Cramer <david@sentry.io>
dcramer
marked this pull request as ready for review
August 9, 2026 23:34
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3255ea7. Configure here.
Review feedback: check-run names are workflow-controlled, so put them in untrustedText. Load failing runs by suite id, and build the suite browser url ourselves because GitHub does not send html_url on check suites. Co-Authored-By: David Cramer <david@sentry.io>
Contributor
Author
|
Addressed the three review findings in dbea380:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1362.
Check suite events only said that checks failed or recovered. Junior then had to look up the head SHA, suite link, and failed checks.
This PR adds optional trusted
dataon resource events. GitHub check suite events fill that data with system ids and urls:html_url)Failed check names are workflow-controlled, so they go in
untrustedText, not trusted data.On failed suites, Junior may load failed check runs with one installation-token call scoped to that suite. If that call fails, the event still includes the suite facts from the webhook.
checks.recoveredmeans one suite recovered. It does not mean the whole PR is green.Ops note: the GitHub App needs
Checks: Readto load failed check-run ids/urls.