Skip to content

Conversation

@runningcode
Copy link
Contributor

@runningcode runningcode commented Jul 28, 2025

Command is launchpad distribution <path to apk>

Copy link
Contributor Author

runningcode commented Jul 28, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@runningcode runningcode requested a review from chromy July 28, 2025 12:57
@runningcode runningcode changed the title Add ability to check certificate. Add ability to check apk signature via command line. Jul 28, 2025
@codecov
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 35.29412% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.32%. Comparing base (44b577d) to head (b19de0c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/launchpad/distribution/cli.py 31.25% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   76.44%   76.32%   -0.13%     
==========================================
  Files         131      132       +1     
  Lines       10435    10465      +30     
  Branches     1164     1165       +1     
==========================================
+ Hits         7977     7987      +10     
- Misses       2047     2067      +20     
  Partials      411      411              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@chromy chromy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % init.py file


@click.command()
@click.argument("apk_path", type=click.Path(exists=True, path_type=Path))
@click.option("--verbose", "-v", is_flag=True, help="Enable verbose logging output.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should hoist --verbose to the outer level of the CLI at somepoint - but not in this PR.

@runningcode runningcode merged commit 4a8338d into main Jul 28, 2025
20 of 21 checks passed
@runningcode runningcode deleted the no/add_ability_to_check_certificate branch July 28, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants