-
-
Notifications
You must be signed in to change notification settings - Fork 1
Add ability to check apk signature via command line. #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from pathlib import Path | ||
|
|
||
| import click | ||
|
|
||
| from ..utils.android.apksigner import Apksigner, ApksignerError | ||
| from ..utils.console import console | ||
| from ..utils.logging import setup_logging | ||
|
|
||
|
|
||
| @click.command("distribution") | ||
| @click.argument("apk_path", type=click.Path(exists=True, path_type=Path)) | ||
| @click.option("--verbose", "-v", is_flag=True, help="Enable verbose logging output.") | ||
| def distribution_command(apk_path: Path, verbose: bool) -> None: | ||
| """Print certificate information for an APK file. | ||
|
|
||
| Uses apksigner to extract and display the certificate information | ||
| from the specified APK file. | ||
| """ | ||
| setup_logging(verbose=verbose, quiet=False) | ||
|
|
||
| if not apk_path.suffix.lower() == ".apk": | ||
| console.print(f"[bold red]Error:[/bold red] File must be an APK file, got: {apk_path.suffix}") | ||
| raise click.Abort() | ||
|
|
||
| console.print(f"[bold blue]Analyzing APK certificate:[/bold blue] {apk_path}") | ||
|
|
||
| try: | ||
| apksigner = Apksigner() | ||
| cert_info = apksigner.get_certs(apk_path) | ||
| console.print("\n[bold green]Certificate Information:[/bold green]") | ||
| console.print(cert_info) | ||
| except ApksignerError as e: | ||
| console.print(f"[bold red]Error running apksigner:[/bold red] {e}") | ||
| if verbose: | ||
| console.print(f"Return code: {e.returncode}") | ||
| console.print(f"Stdout: {e.stdout}") | ||
| console.print(f"Stderr: {e.stderr}") | ||
| raise click.Abort() | ||
| except Exception as e: | ||
| console.print(f"[bold red]Unexpected error:[/bold red] {e}") | ||
| if verbose: | ||
| console.print_exception() | ||
| raise click.Abort() | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should hoist
--verboseto the outer level of the CLI at somepoint - but not in this PR.