feat(service): Add span instrumentation to backends - #542
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
jan-auer
marked this pull request as ready for review
July 6, 2026 19:16
lcian
approved these changes
Jul 7, 2026
Member
Author
|
For a moment I was considering to strip the crate names and just leave the last module, but then I came back to the full module. Maybe this is something the UI could collapse in the future. We can for sure improve the span name, however. It currently just duplicates the function name, but there's more information we could put into the span like instrumentation in other environments does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Backend operations now appear as real child spans in Sentry, turning the existing per-request and per-task transactions into full trace waterfalls. They were empty before because the sentry-tracing layer only converts
INFO+ spans by default; the logging layer now forwardsDEBUG+ spans (TRACEstill ignored) and the backend spans moved todebug.GCS/S3 HTTP calls and BigTable RPCs each get a per-attempt span covering the real request duration (method/URL/status, or action/gRPC status), and the tiered, changelog, and per-backend operations are annotated so the waterfall reads top-down. Spans carry small primitive fields (object id, range, part numbers, URLs); payloads, streams, and metadata are excluded.
Observability-only — no behavior changes and console logging is untouched.
Closes FS-412