test(server): Fix flaky test_bandwidth_burst_tolerance - #578
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 87.64% 87.71% +0.06%
==========================================
Files 94 94
Lines 15425 15505 +80
==========================================
+ Hits 13520 13600 +80
Misses 1905 1905
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lcian
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test left only 500ms of margin between the accumulated bandwidth debt and the burst tolerance, so a slow runner would see the debt drain back under the burst and admit the request that should have been rejected. Scaled the rate and burst down so the margin is seconds instead of milliseconds, keeping the same scenario.
Closes FS-459