feat(agent): 👀/🎉 signals, leaner diffs, friendlier tone, own the PR E2E - #145
Open
MathurAditya724 wants to merge 2 commits into
Open
feat(agent): 👀/🎉 signals, leaner diffs, friendlier tone, own the PR E2E#145MathurAditya724 wants to merge 2 commits into
MathurAditya724 wants to merge 2 commits into
Conversation
Server now drops an instant 👀 "eyes" reaction on the comment/issue that
triggers Jared, straight from the webhook handler — the human sees it's
picked up in seconds, independent of sandbox warmup. The agent leaves a
single 🎉 "hooray" reaction on that same trigger once the work is actually
done. Reaction target selection is unit-tested.
Instruction + skill changes:
- Keep diffs minimal: never commit AGENTS.md / .agents / harness overlays or
unrelated files (this is exactly what polluted craft#864). git status /
git diff --staged before every commit.
- deslop is now mandatory before every commit, not "as needed".
- Friendlier, humbler, shorter tone for anything a human reads.
- Own your PR end-to-end: fix actionable review feedback and push it; don't
defer it to "the author of a later commit" and stop. Confirm the push
landed (HEAD == @{u}) before claiming a fix.
- fix-ci: stop busy-polling CI in a loop — push, confirm, comment, stop; the
CI-completion webhook wakes you when the run settles.
Co-authored-by: Cursor <cursoragent@cursor.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
jared | d1c0d7c | Aug 07 2026, 02:13 PM |
BYK on craft#865: "the new model is lazy AF pushing back on all review
comments, like that comment on AGENTS.md". The thread shows the pattern —
told to revert AGENTS.md, Jared argued twice ("harness artifact… leaving
open for the maintainers", "reverting would just be overwritten") before
complying on the third ask, and separately never actioned a "drop this
paragraph" comment until a human pinged "you missed this one".
respond-to-comment now biases hard to action: a concrete reviewer request
is an instruction to carry out, not a debate. Explicitly bans the "it'll be
overwritten / harness artifact / not my responsibility / leaving for the
maintainers" deflections, bans arguing the same point twice, and adds a
step to enumerate open review threads so none are missed. Same "act on
feedback, don't defend your choices" line added to the tone section.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four follow-ups, one PR.
1. Instant reaction signals (👀 / 🎉)
When a human triggers Jared (labels an issue, comments on a PR/issue, leaves a review comment, or submits a review), the webhook handler immediately drops an 👀 "eyes" reaction on the exact thing they touched — fire-and-forget, so it lands in seconds regardless of how long the sandbox takes to warm up. No agent boot required, exactly as asked. The agent then leaves a single 🎉 "hooray" reaction on that same trigger once it's actually finished the work. New
lib/github/reactions.tswith a unit-tested target selector; wired intoroutes/webhooks/github.ts.2. Leaner diffs — no bloat
Agent is now told never to commit
AGENTS.md,.agents/,.lore.md, editor/harness config, or any file unrelated to the task, and togit status/git diff --stagedbefore every commit and unstage stray files. This is the exact thing that pollutedcraft#864(its final commit was literallyrevert: restore AGENTS.md to master). Reinforced inrepo-setuptoo, since that's where the harness overlay lands in the working tree.3. deslop everywhere + friendlier tone
deslopis now mandatory before every commit, not "as needed" (skill-loading order + a hard constraint).4. Own the PR end-to-end (craft#864)
In
craft#864the agent replied to a review comment butSKIPPEDpushing the fix, reasoning it was "a maintainer's follow-up commit… leaving open for that commit's author" — stranding the PR. It also busy-polled CI with bigfor i in seq 1 25loops (165 bash calls in one run). Fixes:@-mention a human; never silently leave it ownerless.git rev-parse HEAD @{u}must match) before claiming "fixed in ".Test plan
vitest run— 123 passed (incl. newreactions.test.ts, 6 cases)biome checkclean on changed filestsc --noEmitclean (validates theoctokit.reactions.*calls)sync-skills --check— runtime.agents/skillstree regenerated, no driftMade with Cursor
Update — reviewer pushback (BYK feedback on craft#865)
BYK on this thread: "the new model is lazy AF pushing back on all review comments, like that comment on AGENTS.md." The threads confirm a real reflex:
So
respond-to-commentnow biases hard to action: a concrete reviewer request is an instruction to carry out, not a debate. It explicitly bans the "it'll be overwritten / harness artifact / not my responsibility / leaving for the maintainers" deflections, bans arguing the same point twice, and adds a step to enumerate open review threads first so none are missed. The tone section gets the same "act on feedback, don't defend your choices" line.