Merged
Conversation
asottile-sentry
force-pushed
the
asottile-sentry-patch-1
branch
2 times, most recently
from
aae43a5 to
9133b95
Compare
asottile-sentry
force-pushed
the
asottile-sentry-patch-1
branch
from
9133b95 to
5336bee
Compare
mdtro
approved these changes
Mar 31, 2023
| - name: Run tests | ||
| run: | | ||
| make test | ||
| collector: |
There was a problem hiding this comment.
Is this needed so you can select it as a required check in branch protection? If so can you add a comment to that affect.
I often find this pattern a little confusing when looking at just the action yaml.
mattgauntseo-sentry
approved these changes
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doing this first so I can remove an upper bound on
redis