Remove obsolete React podspec dependency#382
Merged
HazAT merged 1 commit intogetsentry:masterfrom Mar 26, 2018
Merged
Conversation
Member
|
Thx :) |
Closed
5 tasks
Member
Contributor
Author
|
Hi! I'm sorry to hear that. Let me run some detailed tests first and then I would be able to tell you if my premise was wrong after all and if this PR should be reverted, OK? |
Member
|
@angly-cat OK, thanks for helping with this. |
AndrewJack
reviewed
May 16, 2018
|
|
||
| s.preserve_paths = '*.js' | ||
|
|
||
| s.dependency 'React' |
There was a problem hiding this comment.
If/when you revert. This can be more precise by changing it to:
s.dependency 'React/Core'
Member
There was a problem hiding this comment.
Thx, but I will just revert it back, other plugins also just have s.dependency 'React'
Contributor
Author
|
@HazAT Yes, apparently this was a mistake from my side. I'm sorry for that. Please revert this PR. And it seems like it's not possible to use pod version of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using Sentry with a
React Native-only app.react-native link react-native-sentryaddsRNSentryas a pod. If I includeReactas a pod inPodfile, all is ok. But I explicitly do not includeReactas a pod in myReact Native-only app, because it has many downsides and using-react-as-a-pod-issues. In this caseSentry-pod forces CocoaPods to satisfy this (check the changes of this PR)React-dependency by installing old/obsolete/deprecatedReact0.11, which breaks even more things.Resolution is to remove this dependency.
Check corresponding issues in another repos:
invertase/react-native-firebase#325
invertase/react-native-firebase#324
ocetnik/react-native-background-timer#71