Skip to content

Remove obsolete React podspec dependency #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HazAT merged 1 commit into from
Mar 26, 2018
Merged

Remove obsolete React podspec dependency #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion SentryReactNative.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ Pod::Spec.new do |s|

s.preserve_paths = '*.js'

s.dependency 'React'
Copy link
Copy Markdown

@AndrewJack AndrewJack May 16, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If/when you revert. This can be more precise by changing it to:

s.dependency 'React/Core'

Copy link
Copy Markdown
Member

@HazAT HazAT May 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, but I will just revert it back, other plugins also just have s.dependency 'React'

s.dependency 'Sentry', '~> 3.12.0'
s.dependency 'Sentry/KSCrash', '~> 3.12.0'

Expand Down