feat(conventions): Add measurements#6006
Merged
Merged
Conversation
Dav1dde
approved these changes
May 19, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds measurements functionality to
relay-conventions. Similarly to attributes, there is now a constant for each defined measurement. Moreover, there is a functionmeasurement_to_attributethat maps a measurement to its replacement attribute (if defined). However, this function isn't used yet in this PR.This PR contains no functional changes, it just lays the groundwork for a future change that will use
measurement_to_attribute. The new measurement constants are used everywhere I could find that it would make sense. The lion's share of changed files in this PR is due to therelay_conventions::constsattribute being renamed torelay_conventions::attributes(just calling itconstswould be ambiguous, now that there are also constants for measurements).ref: INGEST-909