feat(eap): Convert measurements to attributes smartly#6007
Conversation
| "browser.web_vital.cls.value": 100.0, | ||
| "browser.web_vital.fcp.value": 200.0, |
There was a problem hiding this comment.
We need to make sure the product can actually deal with these new attributes first. Coalesce etc. must work.
There was a problem hiding this comment.
There is a range of options for how defensive to be here, from "always double write the replacement attribute name and the literal measurement name" to "check if the literal measurement name wants to be backfilled in sentry-conventions.
loewenheim
force-pushed
the
sebastian/measurements-to-attributes
branch
from
4c75553 to
a31a63a
Compare
|
@Dav1dde I've now introduced a feature flag for "smart" measurements conversion. Would appreciate some stylistic critique (naming, how checking the feature/threading through the flag is done). I've also expanded the relevant tests to work with or without the feature. |
Looks good 👍, left some comments and a nit. |
2 participants
Based on #6006.
This uses
measurement_to_attributefrom the previous PR during span V1 -> V2 conversion to convert a measurement to a current attribute, if possible.As can be seen from the tests, this means that in some cases the "directly translated" name (e.g.
"cls") will no longer be present. If we judge this too risky, we can also double write in the conversion, i.e. insert both the bare measurement name and the proper attribute name.ref: INGEST-909.