fix(ds): Strip transactions if they above the tag length limit - #6271
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
loewenheim
approved these changes
Jul 30, 2026
Dav1dde
force-pushed
the
dav1d/transaction-dsc-limit
branch
from
July 30, 2026 07:11
aae82f8 to
495fa6a
Compare
shellmayr
added a commit
to getsentry/sentry
that referenced
this pull request
Jul 30, 2026
…pping them (#120911) - Remove the `has:sentry.dsc.transaction` clause from the `get_eap_transaction_volumes` query in `src/sentry/dynamic_sampling/per_org/queries.py`, so root spans without a transaction name are counted - this aligns the new pipeline with getsentry/relay#6271 - Coalesce missing and empty values to `""` and sum their counts, so the rebalancing model sees one unnamed class rather than two — one of which would have been named `"None"` (which is however not present in the ingestion pipeline) Contributes to TET-2754
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our goal for the moment is parity, the metrics which power dynamic sampling have the transaction stripped if they are too long, so let's also do it for EAP.
This only covers the transaction pipeline, it intentionally does not touch the standalone span pipeline for now.