Skip to content

rfc(decision): Make Sentry Semantic Conversions Mandatory in SDKs#147

Closed
antonpirker wants to merge 3 commits into
mainfrom
rfc/make-sentry-semantic-conversions-mandatory-in-sd-ks
Closed

rfc(decision): Make Sentry Semantic Conversions Mandatory in SDKs#147
antonpirker wants to merge 3 commits into
mainfrom
rfc/make-sentry-semantic-conversions-mandatory-in-sd-ks

Conversation

@antonpirker

@antonpirker antonpirker commented May 8, 2025

Copy link
Copy Markdown
Contributor

We should make sure, that it is hard to add span attributes that are not listed in our Semantic Conversions.
This should make it impossible to just randomly add attributes that are not documented anywhere.

Rendered RFC

@antonpirker antonpirker force-pushed the rfc/make-sentry-semantic-conversions-mandatory-in-sd-ks branch from ab2f81c to 4e0ed42 Compare May 8, 2025 10:41
@antonpirker

Copy link
Copy Markdown
Contributor Author

As set_attribute() is a public API and designed to be used by the user to add arbitrary attributes to spans, this RFC is not going to work. I withdraw my request.

@antonpirker antonpirker closed this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant