Merged
Conversation
Dimensions are not being properly applied when you seek to a position in the replay. Need to use `setProperty`, otherwise the style attributes get lost.
bruno-garcia
approved these changes
Oct 19, 2023
Member
bruno-garcia
left a comment
bruno-garcia
left a comment
There was a problem hiding this comment.
A test to repro the bug would help avoid regressions here but shipping the fix asap also works for me
Member
Author
|
It actually is covered in sentry-javascript, but we missed it: https://github.com/getsentry/sentry-javascript/pull/8760/files#diff-c0b1773a4acdadc0e23d17df2f9c8a3d13be5a62e01dff6a79e894d58721a84eL174 I'll see how easy it is to add a test here since it'd be easier to spot. |
billyvg
added a commit
that referenced
this pull request
Oct 19, 2023
Follow-up to #117 - adds a test case
Member
|
TODO: I guess we should also upstream this? |
billyvg
added a commit
that referenced
this pull request
Oct 20, 2023
Follow-up to #117 - adds a test case
billyvg
added a commit
that referenced
this pull request
Oct 20, 2023
Dimensions are not being properly applied when you seek to a position in the replay. Need to use `setProperty`, otherwise the style attributes get lost.
billyvg
added a commit
that referenced
this pull request
Oct 20, 2023
Follow-up to #117 - adds a test case
billyvg
added a commit
that referenced
this pull request
Oct 20, 2023
Dimensions are not being properly applied when you seek to a position in the replay. Need to use `setProperty`, otherwise the style attributes get lost.
billyvg
added a commit
that referenced
this pull request
Oct 20, 2023
Follow-up to #117 - adds a test case
billyvg
added a commit
that referenced
this pull request
Apr 26, 2024
Dimensions are not being properly applied when you seek to a position in the replay. Need to use `setProperty`, otherwise the style attributes get lost.
billyvg
added a commit
that referenced
this pull request
Apr 26, 2024
Follow-up to #117 - adds a test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dimensions are not being properly applied when you seek to a position in the replay. Need to use
setProperty, otherwise the style attributes get lost.