feat(snapshot): Update blocked image dimensions after load #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blocked images do not have the correct dimensions if we snapshot before the image finishes loading. This attaches an event listener to the image and creates a mutation event to set the correct width/height of the image placeholder element after the image is loaded.
billyvg
commented
Jul 29, 2025
Comment on lines
-1301
to
-1302
| // this property was not needed in replay side | ||
| delete serializedNode.needBlock; |
Member
Author
There was a problem hiding this comment.
I moved this further down the function so that we can make use of needBlock before deleting.
Co-authored-by: Charly Gomez <charly.gomez@sentry.io>
billyvg
deleted the
billy/replay-565-blocked-image-not-recorded-with-correct-dimensions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked images do not have the correct dimensions if we snapshot before the image finishes loading. This attaches an event listener to the image and creates a mutation event to set the correct width/height of the image placeholder element after the image is loaded.