feat(replay): Manual snapshots can skip rAF #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes `snapshot()` to skip rAF. This should fix some cases where manual snapshots were not able to capture the canvas buffer. Cleaned up the code a bit and fixes the `initCanvasFPSObserver` so we can properly clean-up the recording loop.
billyvg
changed the title
billyvg
commented
Aug 7, 2025
| }); | ||
| } | ||
|
|
||
| public snapshot(canvasElement?: HTMLCanvasElement) { |
Member
Author
There was a problem hiding this comment.
Moved so its grouped with the other public methods.
| rafId = onRequestAnimationFrame(rafCallback); | ||
|
|
||
| this.restoreHandlers.push(() => { | ||
| cancelAnimationFrame(rafId); |
Member
Author
There was a problem hiding this comment.
This didn't work as expected since takeSnapshot() loops on itself and this rafId is only for the first call.
Comment on lines
377
to
381
| private getCanvasElements( | ||
| blockClass?: blockClass, | ||
| blockSelector?: string | null, | ||
| unblockSelector?: string | null, | ||
| ): HTMLCanvasElement[] { |
Member
Author
There was a problem hiding this comment.
Extracted from inside of takeSnapshot
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
3 tasks
chargome
approved these changes
Aug 12, 2025
billyvg
deleted the
billy/js-829-replay-manual-snapshot-results-in-blank-or-missing-frames-in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to
snapshot()to skip rAF. This should fix some cases where manual snapshots were not able to capture the canvas buffer.Also cleans up the code a bit and fixes the
initCanvasFPSObserverso we can properly clean-up the recording loop.