feat(py3): Add Python 3 support via SENTRY_PYTHON3 env variable #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuarli
reviewed
Oct 14, 2020
Member
joshuarli
left a comment
joshuarli
left a comment
There was a problem hiding this comment.
Can this be SENTRY_PYTHON3 to avoid confusion, since that's what's used throughout sentry (mostly CI but it also appears in setup.py)?
BYK
changed the title
joshuarli
reviewed
Oct 14, 2020
joshuarli
approved these changes
Oct 14, 2020
BYK
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 14, 2020
With this PR, we now rely on the built-in `SENTRY_PYTHON3` env var support, introduced in getsentry/self-hosted#702. This PR also refactors common env variable usages and centralizes them.
BYK
added a commit
to getsentry/sentry
that referenced
this pull request
Oct 14, 2020
With this PR, we now rely on the built-in `SENTRY_PYTHON3` env var support, introduced in getsentry/self-hosted#702. This PR also refactors common env variable usages and centralizes them.
scefali
pushed a commit
to getsentry/sentry
that referenced
this pull request
Oct 15, 2020
With this PR, we now rely on the built-in `SENTRY_PYTHON3` env var support, introduced in getsentry/self-hosted#702. This PR also refactors common env variable usages and centralizes them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.