Skip to content

Conversation

@BYK
Copy link
Member

@BYK BYK commented Oct 14, 2020

With this PR, we now rely on the built-in SENTRY_PYTHON3 env var support, introduced in getsentry/self-hosted#702. This PR also refactors common env variable usages and centralizes them.

With this PR, we now rely on the built-in `SENTRY_PYTHON3` env var support, introduced in getsentry/self-hosted#702. This PR also refactors common env variable usages and centralizes them.
@BYK
Copy link
Member Author

BYK commented Oct 14, 2020

Travis failure is unrelated.

@BYK BYK requested a review from billyvg October 14, 2020 19:37
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BYK BYK merged commit dd56ab5 into master Oct 14, 2020
@BYK BYK deleted the byk/ref/py3-gcb-tests branch October 14, 2020 20:25
scefali pushed a commit that referenced this pull request Oct 15, 2020
With this PR, we now rely on the built-in `SENTRY_PYTHON3` env var support, introduced in getsentry/self-hosted#702. This PR also refactors common env variable usages and centralizes them.
BYK added a commit that referenced this pull request Oct 15, 2020
BYK added a commit that referenced this pull request Oct 15, 2020
BYK added a commit that referenced this pull request Oct 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants