Skip to content

Conversation

@vaind
Copy link
Contributor

@vaind vaind commented Feb 21, 2023

This fixes the 246 warnings produced by cargo check --features clap/deprecated in order to be able to update to clap v4.

  • value_of() with get_one()
  • is_present() with contains_id()
  • values_of() with get_many()
  • validator() with value_parser()
  • multiple_occurrences() with action(ArgAction::Append)
  • possible_values() with PossibleValueParser
  • Arg::with_name with Arg::new

@vaind vaind force-pushed the chore/update-clap branch from a3ae9fb to 4ec3159 Compare February 21, 2023 16:43
@vaind vaind requested a review from kamilogorek February 21, 2023 20:07
Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's quite a lot of changes, but I hope our integration tests covered enough cases to make us confident merging it 👀

@vaind vaind merged commit f9edc91 into master Feb 22, 2023
@vaind vaind deleted the chore/update-clap branch February 22, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants