fix: warn about missing SENTRY_RELEASE when it's set to empty string#2394
Merged
fix: warn about missing SENTRY_RELEASE when it's set to empty string#2394
Conversation
Member
|
@a-hariti i think this will only cover the environment variable. However, release can also be set in other ways, e.g. via command line argument. I think we should instead change where we serialize the data for the HTTP request. I would be happy to point you in the right direction. |
Collaborator
Author
|
Yes, I would love to |
a-hariti
commented
Feb 19, 2025
Collaborator
Author
Member
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Looks good, nice first PR! I noticed a couple small things to change before we merge, but I'll approve once those are addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this covers all instances/paths
closes #2385