Merged
Conversation
The `Makefile` was added in 53a4f3b, and at that time, it was called from CI. Since then, our CI no longer calls `make` to build, lint, and test Sentry CLI, so the `Makefile` no longer appears to serve much of a purpose. So, let's delete the file to avoid confusing anyone as to its purpose.
Member
Author
|
I also ran the release build workflow against this PR and it passes, indicating that we don't seem to need the |
loewenheim
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Makefilewas added in 53a4f3b, and at that time, it was called from CI. Since then, our CI no longer callsmaketo build, lint, and test Sentry CLI, so theMakefileno longer appears to serve much of a purpose.So, let's delete the file to avoid confusing anyone as to its purpose.