Add frontend for search#2656
Closed
szokeasaurusrex wants to merge 1 commit into07-28-demo_7cb8dd19__demo_add_server_apifrom
Closed
Add frontend for search#2656szokeasaurusrex wants to merge 1 commit into07-28-demo_7cb8dd19__demo_add_server_apifrom
szokeasaurusrex wants to merge 1 commit into07-28-demo_7cb8dd19__demo_add_server_apifrom
Conversation
Closed
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| setError(error.message); | ||
| setLoading(false); | ||
| }); | ||
| }, [searchQuery]); // Depend on searchQuery |
There was a problem hiding this comment.
Bug: TaskSearch Hook Issues: Unnecessary Calls, Debouncing, Error Persistence
The TaskSearch component's useEffect hook has several issues:
- It makes an unnecessary initial API call on mount with an empty search query.
- It triggers an API request on every keystroke without debouncing, leading to excessive network traffic and race conditions where out-of-order API responses can display outdated search results.
- The error state is not cleared before new requests, causing previous errors to persist despite successful subsequent searches.
Locations (1)
szokeasaurusrex
force-pushed
the
07-28-demo_08faa39b_add_frontend_for_search
branch
from
507789e to
7c70a74
Compare
szokeasaurusrex
force-pushed
the
07-28-demo_7cb8dd19__demo_add_server_api
branch
from
27b1b84 to
28ef4f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.