Skip to content

ci(rust): Auto-update rust-toolchain.toml#2746

Merged
szokeasaurusrex merged 2 commits intomasterfrom
szokeasaurusrex/update-toolchain-action
Sep 15, 2025
Merged

ci(rust): Auto-update rust-toolchain.toml#2746
szokeasaurusrex merged 2 commits intomasterfrom
szokeasaurusrex/update-toolchain-action

Conversation

@szokeasaurusrex
Copy link
Copy Markdown
Member

@szokeasaurusrex szokeasaurusrex commented Sep 12, 2025

Automatically make PRs to bump the Rust toolchain version pinned in rust-toolchain.toml.

The PRs will look like #2748, which was generated against #2747, which builds on top of this PR.

Fixes CLI-167

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/update-toolchain-action branch 3 times, most recently from 8e765eb to 2484d23 Compare September 12, 2025 16:00
@linear
Copy link
Copy Markdown

linear bot commented Sep 12, 2025

@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review September 12, 2025 16:15
@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner September 12, 2025 16:15
cursor[bot]

This comment was marked as outdated.

@lcian
Copy link
Copy Markdown
Member

lcian commented Sep 15, 2025

@szokeasaurusrex I'm ready to approve this but I see CI is failing here for some reason. Might be a flake?
Other than that, would it make sense for the action to also run a cargo clippy --fix or similar, to also auto fix any new lints?

@szokeasaurusrex
Copy link
Copy Markdown
Member Author

Yeah, test failures are unrelated, they were also failing on master last week. It seems to be failing consistently though, not a flake. Gonna investigate this.

Autofixing new lints sounds like a good idea though! But maybe I'll make another PR to add that

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/update-toolchain-action branch from 2484d23 to 278cb0b Compare September 15, 2025 12:43
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/update-toolchain-action branch from 278cb0b to b974c71 Compare September 15, 2025 13:02
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/update-toolchain-action branch from b974c71 to 4a1d551 Compare September 15, 2025 13:04
@szokeasaurusrex szokeasaurusrex merged commit aa2c570 into master Sep 15, 2025
25 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/update-toolchain-action branch September 15, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants