ci(node): Resolve browserslist to 4.25.4#2754
Merged
szokeasaurusrex merged 1 commit intomasterfrom Sep 15, 2025
Merged
Conversation
szokeasaurusrex
changed the title
baseline-browser-mapping 2.8.3baseline-browser-mapping 2.8.2 & 2.8.3
szokeasaurusrex
changed the title
baseline-browser-mapping 2.8.2 & 2.8.3browserslist==4.25.4
szokeasaurusrex
changed the title
browserslist==4.25.4browserslist to 4.25.4
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-node-test
branch
2 times, most recently
from
726626f to
d05260a
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-node-test
branch
from
d05260a to
27b9949
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-node-test
branch
from
27b9949 to
9beab3b
Compare
Lms24
reviewed
Sep 15, 2025
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-node-test
branch
from
9beab3b to
42bd2d9
Compare
Also, commit a `package-lock.json` (version 1, so we can use it with npm 6), so that we pin our dependencies in CI. Use `npm ci` to ensure we respect the lockfile. See browserslist/browserslist#905 (comment)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-node-test
branch
from
42bd2d9 to
ec2a88b
Compare
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Lms24
approved these changes
Sep 15, 2025
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
thanks for fixing and cleaning up the package manager duality!
| "yarn": "1.22.19" | ||
| }, | ||
| "overrides": { | ||
| "browserslist": "<4.26.0 || >4.26.0" |
Member
There was a problem hiding this comment.
good idea on making this forwards-compatible!
I'd still recommend keeping an eye on https://github.com/browserslist/browserslist to see when we don't need the resolution at all anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, commit a
package-lock.json(version 1, so we can use it with npm 6), so that we pin our dependencies in CI. Usenpm cito ensure we respect the lockfile.See browserslist/browserslist#905 (comment)