Skip to content

chore(releases): Remove release finalize --started option #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: szokeasaurusrex/no-live-rejectOnError
Choose a base branch
from
+1 −15
Open

chore(releases): Remove release finalize --started option #2972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ we should rename this section to "Unreleased" -->
- `api_key` configuration file field
- `apiKey` option in the JavaScript API
- Removed the `upload-proguard` subcommand's `--app-id`, `--version`, `--version-code`, `--android-manifest`, and `--platform` arguments ([#2876](https://github.com/getsentry/sentry-cli/pull/2876), [#2940](https://github.com/getsentry/sentry-cli/pull/2940), [#2948](https://github.com/getsentry/sentry-cli/pull/2948)). Users using these arguments should stop using them, as they are unnecessary. The information passed to these arguments is no longer visible in Sentry.
- Removed the `--started` argument from the `sentry-cli releases finalize` command ([#XXXX](TODO)). This argument is a no-op, so any users using it should simply stop using it.
- In the JS API, the `SentryCli.execute` method's `live` parameter now only takes boolean values ([#2971](https://github.com/getsentry/sentry-cli/pull/2971)). Setting `live` to `true` now behaves like `'rejectOnError'` did previously, with a zero exit status resolving the returned promise with `"success (live mode)"` and a non-zero status rejecting the promise with an error message.
- In the JS API, the `option` parameter to `Releases.uploadSourceMaps` no longer takes a `live` property ([#2971](https://github.com/getsentry/sentry-cli/pull/2971)). We now always execute the command with `live` set to `true`.

Expand Down
15 changes: 0 additions & 15 deletions src/commands/releases/finalize.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,6 @@ pub fn make_command(command: Command) -> Command {
.value_name("URL")
.help("Optional URL to the release for information purposes."),
)
.arg(
Arg::new("started")
.long("started")
.hide(true)
.value_parser(get_timestamp)
.value_name("TIMESTAMP")
.help("[DEPRECATED] This value is ignored."),
)
.arg(
Arg::new("released")
.long("released")
Expand All @@ -40,13 +32,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
#[expect(clippy::unwrap_used, reason = "legacy code")]
let version = matches.get_one::<String>("version").unwrap();

if matches.get_one::<DateTime<Utc>>("started").is_some() {
log::warn!(
"The --started flag is deprecated. Its value is ignored, \
and the argument will be completely removed in a future version."
);
}

api.authenticated()?.update_release(
&config.get_org(matches)?,
version,
Expand Down
Loading