feat(proguard): upload-proguard → proguard upload#3174
Merged
szokeasaurusrex merged 1 commit intomasterfrom Mar 4, 2026
Merged
feat(proguard): upload-proguard → proguard upload#3174szokeasaurusrex merged 1 commit intomasterfrom
upload-proguard → proguard upload#3174szokeasaurusrex merged 1 commit intomasterfrom
Conversation
Contributor
|
szokeasaurusrex
commented
Mar 3, 2026
szokeasaurusrex
changed the title
upload-proguard → proguard upload
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload
branch
from
d83e440 to
124418a
Compare
szokeasaurusrex
commented
Mar 3, 2026
szokeasaurusrex
added a commit
that referenced
this pull request
Mar 4, 2026
Move the `sentry-cli upload-proguard` command to `sentry-cli proguard upload`. This new API matches the API for the `debug-files upload` and `sourcemap upload` commands. This API will also enable us to add new subcommands, which will be useful for #3173. `sentry-cli upload-proguard` is retained as an alias to `sentry-cli proguard upload`, and we intend to keep it around for the foreseeable future, so no one needs to migrate.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload
branch
from
124418a to
718df71
Compare
szokeasaurusrex
added a commit
that referenced
this pull request
Mar 4, 2026
This is the follow-up PR [referenced here](https://github.com/getsentry/sentry-cli/pull/3174/changes#r2878536509) on #3174.
Move the `sentry-cli upload-proguard` command to `sentry-cli proguard upload`. This new API matches the API for the `debug-files upload` and `sourcemap upload` commands. This API will also enable us to add new subcommands, which will be useful for #3173. `sentry-cli upload-proguard` is retained as an alias to `sentry-cli proguard upload`, and we intend to keep it around for the foreseeable future, so no one needs to migrate.
szokeasaurusrex
added a commit
that referenced
this pull request
Mar 4, 2026
This is the follow-up PR [referenced here](https://github.com/getsentry/sentry-cli/pull/3174/changes#r2878536509) on #3174.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/proguard-upload
branch
from
718df71 to
be51270
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| } | ||
| })), | ||
| ] | ||
| .into(), |
There was a problem hiding this comment.
Redundant AnyOf wrapping order-independent Matcher::Json matchers
Low Severity
In chunk_upload_two_files, the Matcher::AnyOf wraps two Matcher::Json values that differ only in JSON object key ordering. Since mockito's Matcher::Json uses assert-json-diff under the hood, which performs order-independent comparison of object keys, the AnyOf with both orderings is redundant. A single Matcher::Json would achieve the same result. The original test in upload_proguard.rs needed AnyOf because it used string-based matching (order-dependent), but the switch to Matcher::Json made it unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
sentry-cli upload-proguardcommand tosentry-cli proguard upload.This new API matches the API for the
debug-files uploadandsourcemap uploadcommands. This API will also enable us to add new subcommands, which will be useful for #3173.sentry-cli upload-proguardis retained as an alias tosentry-cli proguard upload, and we intend to keep it around for the foreseeable future, so no one needs to migrate.