fix(proguard): Drop redundant line info validation for mapping files#3192
Merged
fix(proguard): Drop redundant line info validation for mapping files#3192
Conversation
The proguard mapper can remap and support files without line information, so the has_line_info() check was unnecessarily rejecting valid mappings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
romtsn
force-pushed
the
rz/fix/drop-proguard-line-info-check
branch
from
78b4dd3 to
8248ef7
Compare
Since is_usable() now always returns true for Proguard mappings, the Proguard arm in get_problem() is dead code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
romtsn
force-pushed
the
rz/fix/drop-proguard-line-info-check
branch
from
8248ef7 to
af19d68
Compare
Member
szokeasaurusrex
left a comment
szokeasaurusrex
left a comment
There was a problem hiding this comment.
Left some comments; most important thing is about the tests
tests/integration/_cases/proguard/proguard-uuid-invalid-mapping.trycmd
Outdated
Show resolved
Hide resolved
- Use exhaustive match instead of wildcard in is_usable() and get_problem() to catch future DifFile variants at compile time - Add test verifying UUID generation succeeds for mappings without line info Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
szokeasaurusrex
approved these changes
Mar 9, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Mar 9, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_line_info()check that rejected proguard mapping files without line information — our proguard mapper can handle these files fineProguardMappingErrorenum and convertTryFrom<ByteView>toFrom<ByteView>DifFile::is_usable()to always returntruefor proguard mappings, consistent with the changeTest plan
proguard-uuid-invalid-mapping.trycmdtestproguard-upload-no-uploadandupload_proguard-no-uploadtest snapshots🤖 Generated with Claude Code