fix(snapshots): Preserve subdirectory structure in manifest keys#3269
Merged
NicoHinderling merged 2 commits intomasterfrom Apr 15, 2026
Merged
fix(snapshots): Preserve subdirectory structure in manifest keys#3269NicoHinderling merged 2 commits intomasterfrom
NicoHinderling merged 2 commits intomasterfrom
Conversation
Use full relative paths (e.g. settings/profile.png) instead of bare filenames (e.g. profile.png) as manifest keys when uploading build snapshots. Previously, images in different subdirectories with the same filename would collide and only the first would be uploaded. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
NicoHinderling
force-pushed
the
fix/snapshot-preserve-relative-paths
branch
from
2c1f889 to
1486e9c
Compare
rbro112
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use full relative paths (e.g.
settings/profile.png) instead of barefilenames (e.g.
profile.png) as manifest keys when uploading buildsnapshots.
Previously,
upload_imagesextracted only the filename from each image'srelative path to use as the manifest key. This meant images in different
subdirectories with the same filename would collide — only the first
encountered would be uploaded, and the rest silently skipped with a
warning.
Now the manifest key includes the full relative path from the upload
directory, preserving the subdirectory structure and eliminating false
collisions.