fix(snapshots): Remove Sentry auth token from objectstore client#3286
Merged
fix(snapshots): Remove Sentry auth token from objectstore client#3286
Conversation
The objectstore client was injecting the user's Sentry auth token as a default Authorization header on all requests. Since the objectstore URL comes from the server API response and can point to external storage hosts (S3, GCS, etc.), this leaked the Sentry token to third-party services. The objectstore already authenticates via its own auth_token field (x-os-auth header), making the Sentry token unnecessary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The auth() method on AuthenticatedApi no longer has any callers after removing the token leak. CI builds with -Dwarnings, which promotes the dead_code warning to a compilation error. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
szokeasaurusrex
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attaching the Sentry auth token to Objectstore requests is no longer needed after getsentry/sentry#114288, as authentication will be performed by Objectstore through its auth mechanism and its own header, which we already pass.
Part of FS-344