fix(js): Prevent argument injection via type coercion in serializeOptions#3287
Merged
Merged
Conversation
JPeer264
force-pushed
the
fix/argument-injection-type-coercion
branch
2 times, most recently
from
8c0a8e4 to
699941f
Compare
Member
|
I'll let someone from the JS SDK team review this |
andreiborza
approved these changes
May 11, 2026
…ions Add runtime type validation for string/number options to match existing validation for array and boolean types. Wrap arguments in array literal to prevent concat() from flattening array inputs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
JPeer264
force-pushed
the
fix/argument-injection-type-coercion
branch
from
699941f to
c2ef4bf
Compare
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add runtime type validation for string/number options to match existing validation for array and boolean types. Wrap arguments in array literal to prevent concat() from flattening array inputs.
(there is no ticket for it)
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.