Skip to content

fix: Various fixes#3308

Merged
szokeasaurusrex merged 7 commits into
masterfrom
szokeasaurusrex/security-fixes
May 21, 2026
Merged

fix: Various fixes#3308
szokeasaurusrex merged 7 commits into
masterfrom
szokeasaurusrex/security-fixes

Conversation

@szokeasaurusrex
Copy link
Copy Markdown
Member

@szokeasaurusrex szokeasaurusrex commented May 21, 2026

szokeasaurusrex and others added 7 commits May 21, 2026 14:00
Only disable SSL verification when the relevant field is defined in the
config and case-insensitively equal to `"false"`. Previously, SSL
verification was disabled whenever the option was set, but not
case-sensitively equal to `"true"`, which could lead to the case where
users who set the option to `"True"` having SSL verification
unintentionally disabled.

#skip-changelog

Fixes
[SDK-1238](https://linear.app/getsentry/issue/SDK-1238/sentry-cli-strict-string-comparison-for-ssl-verify-setting-silently)
In hindsight, not sure this change is worth the added complexity. But I
suppose it is a bit safer if we check the checksums after download.

#skip-changelog

Fixes
[SDK-1235](https://linear.app/getsentry/issue/SDK-1235/sentry-cli-self-update-binary-downloaded-without-integrity)
Ensure config files have the correct permissions, even when overwriting
an existing file, by first creating them as a brand new temporary file,
then atomically renaming them over any exisiting file.

Fixes
[SDK-1234](https://linear.app/getsentry/issue/SDK-1234/sentry-cli-config-file-permissions-not-enforced-on-pre-existing-files)
@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner May 21, 2026 13:46
@szokeasaurusrex szokeasaurusrex requested a review from dingsdax May 21, 2026 13:46
@github-actions
Copy link
Copy Markdown
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Fixes

- Various fixes ([#3308](https://github.com/getsentry/sentry-cli/pull/3308))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against e344276

szokeasaurusrex added a commit that referenced this pull request May 21, 2026
Backport of #3308 to `v2`

Contains the following commits, which correspond to PRs from a private
repo:

-
[`244d5a0`](244d5a0):
changelog update
-
[`3e389f0`](3e389f0):
getsentry/sentry-cli-security-fixes#13
-
[`5878120`](5878120):
getsentry/sentry-cli-security-fixes#22
-
[`4f410a6`](4f410a6):
getsentry/sentry-cli-security-fixes#18
-
[`55c52fb`](55c52fb):
getsentry/sentry-cli-security-fixes#19
-
[`578acff`](578acff):
getsentry/sentry-cli-security-fixes#21
-
[`18484cf`](18484cf):
getsentry/sentry-cli-security-fixes#11


#skip-changelog
@szokeasaurusrex szokeasaurusrex merged commit 69f5028 into master May 21, 2026
28 of 29 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/security-fixes branch May 21, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants