feat(attributes): Add sentry.metric.source#476
Conversation
This is an attribute that can be used to attribute the source of a metric; for example, Relay can use it to indicate that a metric originated from an ingested span.
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Lms24
left a comment
There was a problem hiding this comment.
Generally no objections just a thought: Have we considered reusing sentry.origin?
The only thing that speaks a bit against sentry.metric.source is that there's sentry.span.source and it has a different meaning. Though we'll likely deprecate sentry.span.source anyway, so it's not too big a deal.
For our (Relay's) purposes, we're passing through |
|
While I don't exactly remember why we didn't consider re-using the |
Lms24
left a comment
There was a problem hiding this comment.
Makes sense, thx for explaining!
Description
This is an attribute that can be used to attribute the source of a metric; for example, Relay can use it to indicate that a metric originated from an ingested span.
PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.nextjs.function_id, notfunction_id)apply_scrubbing(i.e.manualorauto. Useneveronly for values that should never be scrubbed such as IDs)