Skip to content

feat(attributes): Add sentry.pageload.span_id attribute#495

Merged
Lms24 merged 2 commits into
mainfrom
lms/feat-attr-setry.pageload.span_id
Jul 14, 2026
Merged

feat(attributes): Add sentry.pageload.span_id attribute#495
Lms24 merged 2 commits into
mainfrom
lms/feat-attr-setry.pageload.span_id

Conversation

@Lms24

@Lms24 Lms24 commented Jul 14, 2026

Copy link
Copy Markdown
Member

Description

Already sent by the browser SDK on v1 and v2 web vital spans. Also helpful for web vitals as metrics

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate to generate and format code and docs.

If an attribute was added:

  • The attribute is in a namespace (e.g. nextjs.function_id, not function_id)
  • I have used the correct value for apply_scrubbing (i.e. manual or auto. Use never only for values that should never be scrubbed such as IDs)

If an attribute was deprecated:

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add sentry.pageload.span_id attribute by Lms24 in #495
  • Add sentry.relay.ingress and sentry.relay.pipeline by loewenheim in #491
  • Expand grpc attributes by lucas-zimerman in #460
  • Add file.path and file.size by buenaflor in #458

🤖 This preview updates automatically when you update the PR.

@Lms24 Lms24 changed the title feat(attributes): Add try.pageload.span_id attribute feat(attributes): Add setry.pageload.span_id attribute Jul 14, 2026
@Lms24 Lms24 changed the title feat(attributes): Add setry.pageload.span_id attribute feat(attributes): Add sentry.pageload.span_id attribute Jul 14, 2026
@Lms24 Lms24 self-assigned this Jul 14, 2026
@Lms24
Lms24 marked this pull request as ready for review July 14, 2026 07:27
@Lms24
Lms24 requested review from a team, cleptric, mjq and nsdeschenes as code owners July 14, 2026 07:27
Comment thread model/attributes/sentry/sentry__pageload__span_id.json
@Lms24
Lms24 enabled auto-merge (squash) July 14, 2026 07:35

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e8096a5. Configure here.

"type": "string",
"apply_scrubbing": {
"key": "manual"
},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Span ID uses manual scrubbing

Medium Severity

sentry.pageload.span_id is defined with apply_scrubbing manual, but it holds a pageload span identifier used to link web vital spans and metrics. Other Sentry span ID attributes (sentry.segment.id, sentry.replay_id, sentry.trace.parent_span_id) use never, and project guidance treats opaque IDs that way so scrubbing does not break correlation.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e8096a5. Configure here.

@Lms24
Lms24 merged commit 06ad608 into main Jul 14, 2026
17 checks passed
@Lms24
Lms24 deleted the lms/feat-attr-setry.pageload.span_id branch July 14, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants