feat(attributes): Add deprecated messaging.destination_kind - #509
Merged
Conversation
Adds the legacy `messaging.destination_kind` attribute as deprecated (no replacement) for parity with older OTel instrumentations that still emit it, such as the aws-sdk SNS integration. OTel removed it in favor of `messaging.operation.type` + `messaging.destination.name`. Co-Authored-By: Opus 4.8 <noreply@anthropic.com>
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
andreiborza
marked this pull request as ready for review
July 15, 2026 18:00
andreiborza
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
July 15, 2026 18:00
Lms24
approved these changes
Jul 16, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
now models the destination kind via messaging.operation.type and messaging.destination.na
These aren't similar enough to add them as replacements, correct? i think that's fine fwiw, since we couldn't backfill them anyway. Just checking.
Member
Author
|
Yeah I think it's not similar enough. |
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the legacy
messaging.destination_kindattribute to the model, marked deprecated with no replacement.model/attributes/messaging/messaging__destination_kind.jsonMESSAGING_DESTINATION_KIND) and Python exports viayarn generate.Why
Older OTel instrumentations still emit
messaging.destination_kind(e.g. the aws-sdk SNS instrumentation the Sentry JS SDK ports for parity). OTel has since removed it in favor ofmessaging.operation.type+messaging.destination.name, so it's modeled here as deprecated (_status: null, no replacement).