Skip to content

feat(op): Add router span operation - #551

Merged
msonnb merged 2 commits into
mainfrom
ms/op-routing
Aug 10, 2026
Merged

feat(op): Add router span operation#551
msonnb merged 2 commits into
mainfrom
ms/op-routing

Conversation

@msonnb

@msonnb msonnb commented Aug 4, 2026

Copy link
Copy Markdown
Member

Description

Register the router operation and a new routing category for work performed by an application router, along with its span name inference rules.

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate to generate and format code and docs.

If an attribute was added:

  • The attribute is in a namespace (e.g. nextjs.function_id, not function_id)
  • I have used the correct value for apply_scrubbing (i.e. manual or auto. Use never only for values that should never be scrubbed such as IDs)

If an attribute was deprecated:

@msonnb
msonnb requested review from a team, Lms24, cleptric, mjq and nsdeschenes as code owners August 4, 2026 10:03
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • (op) Add router span operation by msonnb in #551

Internal Changes 🔧

Deps

  • Bump dompurify from 3.4.12 to 3.4.13 by dependabot in #559
  • Bump js-yaml from 4.3.0 to 4.3.1 by dependabot in #560

Other

  • Unstale yarn.lock by Lms24 in #561

🤖 This preview updates automatically when you update the PR.

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a description rule as well. As discussed, we can also include url.path as another fallback attribute for description (but not for name)

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my end! cc @mjq @nsdeschenes are you fine with the description and name rules?

msonnb and others added 2 commits August 10, 2026 12:01
Register the `router` operation for work performed by an application router,
along with its span name inference rules (model/name/routing.json).

Generated artifacts (op.ts, op.rs) regenerated via `yarn generate`.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@msonnb
msonnb merged commit 40f0944 into main Aug 10, 2026
16 checks passed
@msonnb
msonnb deleted the ms/op-routing branch August 10, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants