Skip to content

feat(op): Add handler op - #554

Merged
msonnb merged 3 commits into
mainfrom
ms/request-handler-op
Aug 10, 2026
Merged

feat(op): Add handler op#554
msonnb merged 3 commits into
mainfrom
ms/request-handler-op

Conversation

@msonnb

@msonnb msonnb commented Aug 4, 2026

Copy link
Copy Markdown
Member

Description

Add handler op to the web_server category for spans that instrument http request handlers in server frameworks like express, fastify, etc.

PR Checklist

  • I have run yarn test and verified that the tests pass.
  • I have run yarn generate to generate and format code and docs.

If an attribute was added:

  • The attribute is in a namespace (e.g. nextjs.function_id, not function_id)
  • I have used the correct value for apply_scrubbing (i.e. manual or auto. Use never only for values that should never be scrubbed such as IDs)

If an attribute was deprecated:

@msonnb
msonnb requested review from a team, Lms24, cleptric, mjq and nsdeschenes as code owners August 4, 2026 15:01
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Op

  • Add handler op by msonnb in #554
  • Add router span operation by msonnb in #551

Internal Changes 🔧

Deps

  • Bump dompurify from 3.4.12 to 3.4.13 by dependabot in #559
  • Bump js-yaml from 4.3.0 to 4.3.1 by dependabot in #560

Other

  • Unstale yarn.lock by Lms24 in #561

🤖 This preview updates automatically when you update the PR.

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do handler instead please after discussing this with @cleptric. Thanks!

@msonnb
msonnb force-pushed the ms/request-handler-op branch from b8ac46a to cafc13a Compare August 5, 2026 14:05
@msonnb msonnb changed the title feat(op): Add request_handler op feat(op): Add handler op Aug 5, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit cafc13a. Configure here.

Comment thread model/op/web_server.json

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we'll also need description and name rules for this op. I think we can use the following templates for these spans from checking the use cases in the SDK:

Description:

  1. {http.route}
  2. {url.path}

Name:

  1. {http.route}
  2. "Request handler

Does that sound reasonable to you?

@msonnb
msonnb force-pushed the ms/request-handler-op branch from cafc13a to f23927c Compare August 6, 2026 12:08
@msonnb

msonnb commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

sound reasonable yes! added in f23927c

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@msonnb
msonnb force-pushed the ms/request-handler-op branch from f23927c to e17ce57 Compare August 10, 2026 10:27
@msonnb
msonnb merged commit 5d4e12b into main Aug 10, 2026
16 checks passed
@msonnb
msonnb deleted the ms/request-handler-op branch August 10, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants