Skip to content

Conversation

@kahest
Copy link
Contributor

@kahest kahest commented Dec 6, 2024

DESCRIBE YOUR PR

Adds new "SDK Overhead" menu item + page below the "Mobile SDK Releases" item. Covers Errors etc. in more detail, links to existing product pages for Performance+Profiling+SR.

follow-up to #12063

fixes https://github.com/getsentry/projects/issues/454

Next steps/future work: see https://github.com/getsentry/projects/issues/169

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline: no specific date, target is Dec 12
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 0:55am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 0:55am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 12, 2024 0:55am

@codecov
Copy link

codecov bot commented Dec 6, 2024

Bundle Report

Changes will increase total bundle size by 168 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.34MB 174 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.27MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Added a couple of comments/suggestions.

Copy link
Contributor

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about breadcrumbs impact mitigations, otherwise looks perfect!

@kahest kahest merged commit 7b7064f into master Dec 13, 2024
11 checks passed
@kahest kahest deleted the kahest/rn-sdk-overhead branch December 13, 2024 08:49
Lms24 pushed a commit that referenced this pull request Dec 13, 2024
* adds new SDK overhead page for RN

* update

* update

* update

* update
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants