chore: Add new SDK overhead page for Flutter (+Dart) #12077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 312 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
buenaflor
reviewed
Dec 11, 2024
Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com>
…cs into flutter-sdk-overhead
coolguyzone
reviewed
Dec 11, 2024
coolguyzone
approved these changes
Dec 11, 2024
Contributor
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
Thanks for adding! LGTM 🫡
Member
|
I believe Karl is on PTO. @buenaflor is this good to be merged? |
Contributor
Author
|
@bruno-garcia I'm not on PTO 😅 added @vaind to reviewers, I plan to merge today if possible, tomorrow at the latest |
vaind
reviewed
Dec 12, 2024
Contributor
|
as Ivan mentioned, we don't use background isolates in Flutter so we can remove the sentence or change the wording that native does? not sure |
vaind
approved these changes
Dec 12, 2024
buenaflor
approved these changes
Dec 12, 2024
6 tasks
Lms24
pushed a commit
that referenced
this pull request
Dec 13, 2024
* adds SDK overhead docs for dart and flutter * update * update * Apply suggestions from code review Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com> * update --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Adds new "SDK Overhead" menu item + page below the "Mobile SDK Releases" item. Covers Errors etc. in more detail, links to existing product pages for Performance+Profiling+SR. Also adds a reduced version of the page for Dart as discussed with @buenaflor.
follow-up to #12065
fixes https://github.com/getsentry/projects/issues/455
Next steps/future work: see https://github.com/getsentry/projects/issues/169
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES