-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add note that DSN can be public #1723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested edit below. As to whether to keep the DSN private, it is a combination of your organization's policies and the SDK that you're using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For more info, you can also review this posting - https://forum.sentry.io/t/dsn-private-public/6297
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like how that forum post is framing this as a binary thing. There are shades of gray between fully public and fully private. After my experience, I'd strongly suggest that the policy should be something like, "The DSN should be kept private to the extent possible."
I agree that the worst case is that somebody can send a message to Sentry, but I don't think folks realize just how bad that can be. In our case, it was terrifying and sent our organization into a tailspin until we could figure out what was going on.
I'd also note that it's possible to have different levels of privacy for different DSNs. For example, the ones that are in your JavaScript can be expected to have the occasional false message from an abuser, and your back end can be set up with a different DSN that's kept totally private.
This kind of documentation would have helped us a lot and isn't that hard to understand.