docs(usageStats): Document callback_error client discard reason - #19220
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
github-actions
Bot
added
the
Priority: Needs Triage
Contributor
|
Please update the IS YOUR CHANGE URGENT? section of the PR description:
This information helps the Docs team prioritize your review. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| - **Invalid**: An event was dropped because it contained invalid data (e.g. replay session exceeded maximum allowed length). | ||
| - **Ignored**: An event was ignored by the SDK (for example, a span was ignored by `ignore_spans`). | ||
| - **No Parent Span**: A span was not started or dropped because no parent span was present at span start (for example, auto-instrumented request spans suppressed when the request happens outside an active span). | ||
| - **Callback Error**: An event was dropped because a callback (e.g., `before_send`, `traces_sampler`) threw an error. |
Contributor
There was a problem hiding this comment.
Bug: The new discard reason callback_error was added to product docs but is missing from the authoritative SDK specification, creating an inconsistency for implementers.
Severity: LOW
Suggested Fix
Update the discard reasons table in develop-docs/sdk/telemetry/client-reports.mdx to include the new callback_error reason. Also, add an entry to the spec's changelog to reflect this addition, ensuring consistency between the product docs and the SDK specification.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: docs/product/stats/index.mdx#L99
Potential issue: The pull request adds the `callback_error` discard reason to the
user-facing product documentation. However, it fails to update the authoritative SDK
specification located at `develop-docs/sdk/telemetry/client-reports.mdx`. This violates
the documented process for adding new discard reasons, which requires updating the spec
first. This inconsistency can cause confusion for SDK implementers who rely on the
specification to understand valid discard reasons and may not implement reporting for
`callback_error`.
Did we get this right? 👍 / 👎 to inform future reviews.
Lms24
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the new
callback_errorclient discard reason to usage stats product docs.ref getsentry/sentry#123316
ref getsentry/snuba#8422
ref https://linear.app/getsentry/project/wrap-all-sdk-user-callbacks-in-a-try-catch-6bfdbe9f7268/overview