Document how to upload auto generated bundles/hermes on RN by marandaneto · Pull Request #5236 · getsentry/sentry-docs

marandaneto · 2022-06-30T10:04:00Z

vercel · 2022-06-30T10:04:06Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
sentry-docs	✅ Ready (Inspect)	Visit Preview	Jun 30, 2022 at 3:35PM (UTC)

imatwawana

There's a lot of code formatting on this page that's not in code blocks, and it's hard to read. Code formatting works best when there's a little bit of it within a lot of normal body text. I've made some suggestions for making it easier to read, but I want to take a look at this again after you've made some updates.

imatwawana · 2022-06-30T12:55:00Z


 If you are manually bundling and building React Native apps, follow this three-step process.

+### Upload the auto generated `Bundle` and `Sourcemaps` instead of manually compiling them.


I've just updated the capitalization in the previous edit, but can we shorten this title and do more explaining in the text after the title. Something like:

Suggested change

### Upload the auto generated `Bundle` and `Sourcemaps` instead of manually compiling them.

### Upload the Auto-generated `Bundle` and `Sourcemaps`

Instead of manually compiling them, upload the the auto-generated `Bundle` and `Sourcemaps`.

imatwawana · 2022-06-30T12:56:59Z

+Bundle: `/Users/$user/Library/Developer/Xcode/DerivedData/$projectName-$projectId/Build/Products/Release-$device/main.jsbundle`
+
+Sourcemaps: `/Users/$user/Library/Developer/Xcode/DerivedData/$projectName-$projectId/Build/Intermediates.noindex/$projectName.build/Release-$device/$projectName.build/DerivedSources/main.jsbundle.map`


Same comment as the similar content in the Android section

imatwawana · 2022-06-30T12:57:46Z

+`$projectFolder` is the App's project folder.
+
+`$projectName` is your Project's name.


Suggested change

`$projectFolder` is the App's project folder.

`$projectName` is your Project's name.

`$projectFolder` - the app's project folder.

`$projectName` - your project name.

The suggestion should be your project name.

imatwawana · 2022-06-30T12:59:53Z

+`$user` is your machine's user.
+
+`$projectId` is the Xcode's auto generated Id (e.g. `gmkfjriwzilshxbnndebbqxcwwpn`).
+
+`$device` is the device's target when compiling your app (e.g. `iphonesimulator`).


We avoid using Latin words and abbreviations (etc, e.g, i.e., via). Always spell out "and so on", for example", "in other words" and whatever the best replacement is for "via" (it varies).

Suggested change

`$user` is your machine's user.

`$projectId` is the Xcode's auto generated Id (e.g. `gmkfjriwzilshxbnndebbqxcwwpn`).

`$device` is the device's target when compiling your app (e.g. `iphonesimulator`).

`$user` - your machine's user.

`$projectId` - the Xcode's auto generated Id (for example, `gmkfjriwzilshxbnndebbqxcwwpn`).

`$device` - the device's target when compiling your app (for example, `iphonesimulator`).

imatwawana · 2022-06-30T13:00:19Z

+Bundle: `$projectFolder/android/app/build/generated/assets/react/release/index.android.bundle`
+Sourcemaps: `$projectFolder/android/app/build/generated/sourcemaps/react/release/index.android.bundle.map`


These are hard to read in the preview. Can we put them in code blocks?

imatwawana · 2022-06-30T13:01:44Z

+
+Sourcemaps: `/Users/$user/Library/Developer/Xcode/DerivedData/$projectName-$projectId/Build/Intermediates.noindex/$projectName.build/Release-$device/$projectName.build/DerivedSources/main.jsbundle.map`
+
+File paths represent a `macOS` file system, they might differ from other operating systems.


Suggested change

File paths represent a `macOS` file system, they might differ from other operating systems.

File paths below represent a `macOS` file system, however they might differ on other operating systems.

imatwawana · 2022-06-30T13:02:16Z

+
+If you run `npx react-native run-ios --configuration Release`, the CLI is going to output the following logging:
+
+`info Installing "/Users/$user/Library/Developer/Xcode/DerivedData/$projectName-$projectId/Build/Products/Release-$device/$projectName.app"`


Can we put this in a code block?

imatwawana · 2022-06-30T13:02:59Z

+
+This is the folder you should use to look up the `Bundle` and sourcemaps.
+
+If you decide uploading the auto generated files above, you can skip the `Compile Sourcemaps` step below and go directly to `Upload the Bundle and Source Maps`.


Suggested change

If you decide uploading the auto generated files above, you can skip the `Compile Sourcemaps` step below and go directly to `Upload the Bundle and Source Maps`.

If you decide to upload the auto-generated files above, you can skip the [Compile Sourcemaps](#compile-sourcemaps) step next and go directly to [Upload the Bundle and Source Maps](#upload-the-bundle-and-source-maps)

imatwawana · 2022-06-30T13:05:44Z

 <Note>

-You will upload the **original** bundle (`.bundle`, output from Step 1) and the **composed** source map (`.map`, output from Step 3)
+You will upload the **original** bundle (`.bundle` or `.jsbundle`, output from Step 1) and the **composed** source map (`.map`, output from Step 3)


It's not clear which steps you're referring to here. The three numbered steps in the previous section? If so, then suggest the following:

Suggested change

You will upload the **original** bundle (`.bundle` or `.jsbundle`, output from Step 1) and the **composed** source map (`.map`, output from Step 3)

You will upload the **original** bundle (`.bundle` or `.jsbundle`, output from Step 1) and the **composed** source map (`.map`, output from Step 3) under [Compile Sourcemaps](#compile-sourcemaps).

if you mean the larger steps of this process, then we need to number the big headings and then make the steps under Compile Sourcemaps a, b, c, rather than 1, 2, 3.

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

marandaneto · 2022-07-01T08:16:39Z

Thanks for the review @imatwawana
I'll double-check if this is actually needed, apparently #5241 works better.

philipphofmann

I added a few minor comments. What's needed to make this ready for review, @marandaneto?

philipphofmann · 2022-07-06T09:19:44Z

+`$projectFolder` is the App's project folder.
+
+`$projectName` is your Project's name.


The suggestion should be your project name.

philipphofmann · 2022-07-06T09:23:10Z

+
+File paths represent a `macOS` file system, they might differ from other operating systems.
+
+If you run `npx react-native run-ios --configuration Release`, the CLI is going to output the following logging:


Suggested change

If you run `npx react-native run-ios --configuration Release`, the CLI is going to output the following logging:

If you run `npx react-native run-ios --configuration Release`, the CLI is going to output the following:

philipphofmann · 2022-07-06T09:24:07Z

+
+`info Installing "/Users/$user/Library/Developer/Xcode/DerivedData/$projectName-$projectId/Build/Products/Release-$device/$projectName.app"`
+
+This is the folder you should use to look up the `Bundle` and sourcemaps.


For me, it's not 100% what this refers to. Is it the above output?

marandaneto · 2022-07-07T07:55:28Z

Closed in favor of #5241

Document how to upload auto generated bundles/hermes on RN

817327e

marandaneto requested a review from a team as a code owner June 30, 2022 10:04

marandaneto requested a review from imatwawana June 30, 2022 10:05

vercel Bot deployed to Preview June 30, 2022 10:19 View deployment

fix

437dba8

vercel Bot deployed to Preview June 30, 2022 11:57 View deployment

add line break

9e3ca36

vercel Bot deployed to Preview June 30, 2022 12:27 View deployment

imatwawana reviewed Jun 30, 2022

View reviewed changes

Update src/platforms/react-native/manual-setup/hermes.mdx

540eb7e

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

vercel Bot deployed to Preview June 30, 2022 15:35 View deployment

marandaneto mentioned this pull request Jul 1, 2022

Fix commands for React Native and Hermes #5241

Merged

marandaneto marked this pull request as draft July 1, 2022 08:16

philipphofmann reviewed Jul 6, 2022

View reviewed changes

marandaneto closed this Jul 7, 2022

github-actions Bot locked and limited conversation to collaborators Jul 23, 2022

stephanie-anderson deleted the chore/generated-bundle-hermes branch February 23, 2024 10:28


		If you are manually bundling and building React Native apps, follow this three-step process.

		### Upload the auto generated `Bundle` and `Sourcemaps` instead of manually compiling them.

-### Upload the auto generated `Bundle` and `Sourcemaps` instead of manually compiling them.
+### Upload the Auto-generated `Bundle` and `Sourcemaps`
+Instead of manually compiling them, upload the the auto-generated `Bundle` and `Sourcemaps`.

		Bundle: `/Users/$user/Library/Developer/Xcode/DerivedData/$projectName-$projectId/Build/Products/Release-$device/main.jsbundle`

		Sourcemaps: `/Users/$user/Library/Developer/Xcode/DerivedData/$projectName-$projectId/Build/Intermediates.noindex/$projectName.build/Release-$device/$projectName.build/DerivedSources/main.jsbundle.map`

		`$projectFolder` is the App's project folder.

		`$projectName` is your Project's name.

		Bundle: `$projectFolder/android/app/build/generated/assets/react/release/index.android.bundle`
		Sourcemaps: `$projectFolder/android/app/build/generated/sourcemaps/react/release/index.android.bundle.map`


		Sourcemaps: `/Users/$user/Library/Developer/Xcode/DerivedData/$projectName-$projectId/Build/Intermediates.noindex/$projectName.build/Release-$device/$projectName.build/DerivedSources/main.jsbundle.map`

		File paths represent a `macOS` file system, they might differ from other operating systems.

	File paths represent a `macOS` file system, they might differ from other operating systems.
	File paths below represent a `macOS` file system, however they might differ on other operating systems.


		If you run `npx react-native run-ios --configuration Release`, the CLI is going to output the following logging:

		`info Installing "/Users/$user/Library/Developer/Xcode/DerivedData/$projectName-$projectId/Build/Products/Release-$device/$projectName.app"`


		This is the folder you should use to look up the `Bundle` and sourcemaps.

		If you decide uploading the auto generated files above, you can skip the `Compile Sourcemaps` step below and go directly to `Upload the Bundle and Source Maps`.

	If you decide uploading the auto generated files above, you can skip the `Compile Sourcemaps` step below and go directly to `Upload the Bundle and Source Maps`.
	If you decide to upload the auto-generated files above, you can skip the [Compile Sourcemaps](#compile-sourcemaps) step next and go directly to [Upload the Bundle and Source Maps](#upload-the-bundle-and-source-maps)

	You will upload the original bundle (`.bundle` or `.jsbundle`, output from Step 1) and the composed source map (`.map`, output from Step 3)
	You will upload the original bundle (`.bundle` or `.jsbundle`, output from Step 1) and the composed source map (`.map`, output from Step 3) under [Compile Sourcemaps](#compile-sourcemaps).

Uh oh!

Uh oh!

Conversation

marandaneto commented Jun 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Jun 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

imatwawana left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imatwawana Jun 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marandaneto commented Jul 1, 2022

Uh oh!

philipphofmann left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marandaneto commented Jul 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

marandaneto commented Jun 30, 2022 •

edited

Loading

vercel Bot commented Jun 30, 2022 •

edited

Loading

imatwawana Jun 30, 2022 •

edited

Loading