allow setting hackney opts #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeregrine
reviewed
Jan 17, 2017
Contributor
jeregrine
left a comment
jeregrine
left a comment
There was a problem hiding this comment.
We will need to also update the .rst files as well please.
README.md
Outdated
| | `release` | False | None | | | ||
| | `server_name` | False | None | | | ||
| | `use_error_logger` | False | False | | | ||
| | `hackney_opts` | False | [] | | |
Contributor
There was a problem hiding this comment.
We should link to the hackney request opts https://github.com/benoitc/hackney/blob/master/doc/hackney.md#request5
README.md
Outdated
| our local development machines, exceptions will never be sent, because the | ||
| default value is not in the list of `included_environments`. | ||
|
|
||
| Sentry uses the [hackney HTTP client](https://github.com/benoitc/hackney) for HTTP requests. If you need to set hackney configurations for things like a proxy or different pool, the `hackney_opts` configuration is passed directly to hackney. |
Contributor
There was a problem hiding this comment.
I'd deep link to the options https://github.com/benoitc/hackney/blob/master/doc/hackney.md#request5 (not easy to find)
mitchellhenke
force-pushed
the
hackney-opts
branch
5 times, most recently
from
1548392 to
1623178
Compare
jeregrine
approved these changes
Jan 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #105