Read dsn from system

[rafaeljesus]

Allow read dsn system values for deployment

Closes #107

I kindly ask you to merge it asap as I have a application running in production waiting this feature,

Thanks

[rafaeljesus]

Basically we should be injecting dependences in function signature so we can easily test and move private functions to its own module which we can also test independently so it could be like:

def send_event(%Event{} = event, dsn_parser \\ DsnParser) do
{endpoint, public_key, secret_key} = dsn_parser.parse!
# ....
end

Unfortunately I don't have time to implement it yet, but we can refactor it soon

[mitchellhenke]

I'm not sure that that would be necessary. This kind of pattern would usually come along with specifying a Behaviour, which might be overkill at this point 🙂

[rafaeljesus]

Unfortunately it is public for testing, this should be moved to another module DsnParser and be injected on send_event public function

[mitchellhenke]

I can start reviewing this at some point today, but if you need it ASAP, you can reference your fork in mix with: {:sentry, git: "git://github.com/rafaeljesus/sentry-elixir.git", branch: "read-dsn-from-system"}

[rafaeljesus]

@mitchellhenke Thanks!

[mitchellhenke]

I think this should stay as Application.fetch_env!?

[rafaeljesus]

Yes you are right!

[rafaeljesus]

@mitchellhenke I also just realized that I need to do the same on Mix.Tasks.Sentry.SendTestEvent

[mitchellhenke]

@rafaeljesus It might be easier to have something like Sentry.Client.get_dsn! that fetches from sys/env and parses. Then it can just be called in Sentry.Tasks.Sentry.SendTestEvent, Sentry.Client.send_event/1, and the tests. What do you think?

[rafaeljesus]

@mitchellhenke mate I did the changes you requested may you take a 👀 again?

[rafaeljesus]

Also execute the send_test_event manually with my sentry account and works like a charm

[mitchellhenke]

Thanks for the contribution!