Skip to content

chore(igniter): use latest igniter and drop jason when it's not needed - #1113

Merged
solnic merged 3 commits into
masterfrom
igniter-updates
Jul 10, 2026
Merged

chore(igniter): use latest igniter and drop jason when it's not needed#1113
solnic merged 3 commits into
masterfrom
igniter-updates

Conversation

@solnic

@solnic solnic commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

⚠️ this builds on elixir-version-lockfiles - see #1114 first


Bumps igniter to the latest version and makes it skip adding jason when we don't need it under newer Elixir versions with built-in JSON.

Dep-hell notes:

  • Elixir 1.13 requires older dependencies that still compile on it (hpax must be pinned to 1.0.3 and for sure more are coming soon) - hence elixir-version-lockfiles branch that this one needs added dedicated lock file for Elixir 1.13.
  • Elixir 1.14–1.17 needs pre-ExAST Igniter, because ExAST adds a global Jason encoder that changes Sentry behavior (a test failed due to differences in default JSON serialization of MapSet) - same, needed its own lock file.
  • Elixir 1.18+ can use the latest Igniter safely because it uses native JSON - which we fully embrace too in the SDK 🎉 (and that's our silver lining of this short dependency story 😆)

@solnic
solnic force-pushed the igniter-updates branch 3 times, most recently from b004b91 to f8995d9 Compare July 10, 2026 10:32
@solnic
solnic changed the base branch from master to elixir-version-lockfiles July 10, 2026 10:33
@solnic
solnic force-pushed the igniter-updates branch from f8995d9 to 483a3e4 Compare July 10, 2026 10:34
@solnic
solnic requested review from dingsdax and sl0thentr0py July 10, 2026 10:42
@solnic
solnic marked this pull request as ready for review July 10, 2026 10:42

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 483a3e4. Configure here.

Comment thread mix.exs
@solnic
solnic force-pushed the elixir-version-lockfiles branch from f10a78b to b29c7d8 Compare July 10, 2026 11:02
@solnic
solnic force-pushed the igniter-updates branch from 483a3e4 to 572f234 Compare July 10, 2026 11:02
@solnic solnic changed the title Igniter updates chore(igniter): use latest igniter and drop jason when it's not needed Jul 10, 2026
Base automatically changed from elixir-version-lockfiles to master July 10, 2026 11:11
@solnic
solnic force-pushed the igniter-updates branch from 572f234 to 7ac2883 Compare July 10, 2026 11:14
@solnic
solnic merged commit 79d6580 into master Jul 10, 2026
17 checks passed
@solnic
solnic deleted the igniter-updates branch July 10, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants