Skip to content

Logging on any error from hackney#23

Merged
mitchellhenke merged 1 commit into
masterfrom
js/handle-errors
Aug 12, 2016
Merged

Logging on any error from hackney#23
mitchellhenke merged 1 commit into
masterfrom
js/handle-errors

Conversation

@jeregrine

@jeregrine jeregrine commented Aug 12, 2016

Copy link
Copy Markdown
Contributor

This change is Reviewable

Comment thread lib/logger.ex Outdated
def handle_event({:error, gl, {Logger, msg, _ts, _md}}, state) when node(gl) == node() do
Sentry.capture_logger_message(msg)
def handle_event({:error, gl, {Logger, msg, _ts, metadata}}, state) when node(gl) == node() do
if !Keyword.has_key?(metadata, :skip_sentry) do

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless?

@mitchellhenke mitchellhenke merged commit ffee7bc into master Aug 12, 2016
@mitchellhenke mitchellhenke deleted the js/handle-errors branch August 12, 2016 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants